Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize builder UI with Panel 1.x compatibility #518

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

philippjfr
Copy link
Member

Various updates to ensure the Builder UI renders correctly with Panel 1.x

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (ce5a303) 69.37% compared to head (f51a140) 69.64%.
Report is 3 commits behind head on main.

Files Patch % Lines
lumen/ui/base.py 21.42% 11 Missing ⚠️
lumen/ui/sources.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   69.37%   69.64%   +0.26%     
==========================================
  Files          79       80       +1     
  Lines        9192     9276      +84     
==========================================
+ Hits         6377     6460      +83     
- Misses       2815     2816       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 0885a11 into main Feb 1, 2024
11 checks passed
@philippjfr philippjfr deleted the builder_modernize branch February 1, 2024 12:54
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants